chore: remove name_pretty_override (batch 2)#16870
Conversation
This removes the override from Cloud APIs, as far as google-cloud-compute-v1beta.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the naming conventions for several Google Cloud Python client libraries, primarily by removing redundant "API" suffixes and standardizing product names. The review feedback highlights that some of these changes, such as renaming "AppEngine" to "App Engine" and maintaining specific component names for BeyondCorp packages, are necessary for consistency and clarity. Additionally, the renaming of the "common" package to "Common Operation Metadata type" was flagged as overly specific and potentially misleading, with a suggestion to use "Common" instead.
| "library_type": "OTHER", | ||
| "name": "appenginelogging", | ||
| "name_pretty": "App Engine Logging Protos", | ||
| "name_pretty": "AppEngine Logging", |
There was a problem hiding this comment.
The product name is typically spelled with a space: "App Engine". Using "AppEngine" is non-standard for the pretty name.
| "name_pretty": "AppEngine Logging", | |
| "name_pretty": "App Engine Logging", |
| Python Client for AppEngine Logging | ||
| =================================== |
There was a problem hiding this comment.
The product name should be "App Engine" (with a space).
| Python Client for AppEngine Logging | |
| =================================== | |
| Python Client for App Engine Logging | |
| ==================================== |
| "library_type": "CORE", | ||
| "name": "common", | ||
| "name_pretty": "Google Cloud Common", | ||
| "name_pretty": "Common Operation Metadata type", |
There was a problem hiding this comment.
Renaming the general "common" package to a specific type name like "Common Operation Metadata type" is misleading. If the goal is to simplify, "Common" or "Google Cloud Common" would be more appropriate.
| "name_pretty": "Common Operation Metadata type", | |
| "name_pretty": "Common", |
| Python Client for Common Operation Metadata type | ||
| ================================================ |
There was a problem hiding this comment.
The title "Common Operation Metadata type" is too specific for the google-cloud-common package. Reverting to a more general name like "Common" is recommended.
| Python Client for Common Operation Metadata type | |
| ================================================ | |
| Python Client for Common | |
| ======================== |
2 participants
This removes the override from Cloud APIs, as far as google-cloud-compute-v1beta.