chore: remove description_override (batch 1 - to google-cloud-apphub)#16885
chore: remove description_override (batch 1 - to google-cloud-apphub)#16885parthea merged 3 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes description_override entries from librarian.yaml and updates api_description fields across several package metadata and README files to improve consistency. A review comment identifies the removal of the -W (warnings as errors) flag in packages/google-analytics-data/noxfile.py and suggests restoring it to ensure build configurations remain consistent across the repository.
| session.run( | ||
| "sphinx-build", | ||
| "-W", # warnings as errors | ||
| "-T", # show full traceback on exception |
There was a problem hiding this comment.
The -W flag (warnings as errors) was removed from the documentation build process. Changes to shared configurations, like build flags in noxfile.py, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
| "-T", # show full traceback on exception | |
| "-W", # warnings as errors | |
| "-T", # show full traceback on exception |
References
- Changes to shared configurations, like mypy flags, should be applied consistently across all relevant packages in a dedicated, universal change rather than piecemeal in individual pull requests.
2 participants
No description provided.