feat(dns): generate resource naming for google-cloud-dns-v1#4838
Open
haphungw wants to merge 10 commits intogoogleapis:mainfrom
Open
feat(dns): generate resource naming for google-cloud-dns-v1#4838haphungw wants to merge 10 commits intogoogleapis:mainfrom
haphungw wants to merge 10 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4838 +/- ##
==========================================
+ Coverage 94.07% 94.10% +0.03%
==========================================
Files 219 219
Lines 8521 8521
==========================================
+ Hits 8016 8019 +3
+ Misses 505 502 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
reviewed
Feb 27, 2026
haphungw
force-pushed
the
dns-resource-naming
branch
from
82c368c to
3f0ec0f
Compare
coryan
reviewed
Mar 4, 2026
coryan
reviewed
Mar 4, 2026
westarle
reviewed
Mar 4, 2026
haphungw
force-pushed
the
dns-resource-naming
branch
from
ff0f30d to
26f1193
Compare
coryan
reviewed
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a demo of the generated Rust code for resource_name within
google-cloud-dns-v1.dns-v1is also another Discovery API.