WIP: fix(pubsub): remove actors that are no longer processing messages#4897
Draft
PhongChuong wants to merge 1 commit intogoogleapis:mainfrom
Draft
WIP: fix(pubsub): remove actors that are no longer processing messages#4897PhongChuong wants to merge 1 commit intogoogleapis:mainfrom
PhongChuong wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4897 +/- ##
==========================================
- Coverage 94.55% 94.46% -0.10%
==========================================
Files 213 213
Lines 8378 8384 +6
==========================================
- Hits 7922 7920 -2
- Misses 456 464 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dispatcher now removes batch_actors entries that are no longer processing messages.
A batch actor will close its channel and begin shutdown when it detects that it has no pending messages. Any remaining messages in the channel will be handled by the run loop.
When an actor shutdown, the Dispatcher joins its task and removes the entry from batch_actors. Since sequential actors requires batches to complete before the next batch can be sent, we keep a buffer of messages that arrives after the channel is closed. This buffer is passed onto the next batch actor is needed.
This PR updates 2 tests to reflect the new behavior:
Fixes #4012