test(resource-name): generate code for resource name heuristics demo#4936
Draft
haphungw wants to merge 6 commits intogoogleapis:mainfrom
Draft
test(resource-name): generate code for resource name heuristics demo#4936haphungw wants to merge 6 commits intogoogleapis:mainfrom
haphungw wants to merge 6 commits intogoogleapis:mainfrom
Conversation
83e90de to
3e0de4a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4936 +/- ##
==========================================
+ Coverage 93.94% 93.95% +0.01%
==========================================
Files 221 221
Lines 8538 8538
==========================================
+ Hits 8021 8022 +1
+ Misses 517 516 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westarle
reviewed
Mar 8, 2026
3eb5e71 to
ef1a24b
Compare
ef1a24b to
24e9f24
Compare
westarle
reviewed
Mar 10, 2026
westarle
reviewed
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate all client libraries via
librarian generate --all.We've enabled generating
resource_namevia theresource_name: truetoggle inlibrarian.yamlfor APIs that were previously missing resource names or generating incorrect strings.google-cloud-dns-v1google-cloud-build-v1google-cloud-secret-manager-v1google-cloud-api-keys-v2showcase-v1beta1Depends on:
eligibleServicesallowlist librarian#4469