Skip to content

fix: make stream_query_reasoning_engine async in AsyncClient #6295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olibook wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make stream_query_reasoning_engine async in AsyncClient #6295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/aiplatform_v1/services/reasoning_engine_execution_service/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ async def sample_query_reasoning_engine():
# Done; return the response.
return response

def stream_query_reasoning_engine(
async def stream_query_reasoning_engine(
self,
request: Optional[
Union[
Expand Down Expand Up @@ -541,7 +541,7 @@ async def sample_stream_query_reasoning_engine():
self._client._validate_universe_domain()

# Send the request.
response = rpc(
response = await rpc(
request,
retry=retry,
timeout=timeout,
Expand Down
4 changes: 2 additions & 2 deletions vertexai/agent_engines/_agent_engines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1643,14 +1643,14 @@ def _wrap_async_stream_query_operation(
"""

async def _method(self, **kwargs) -> AsyncIterable[Any]:
response = self.execution_api_client.stream_query_reasoning_engine(
response = await self.execution_async_client.stream_query_reasoning_engine(
request=aip_types.StreamQueryReasoningEngineRequest(
name=self.resource_name,
input=kwargs,
class_method=method_name,
),
)
for chunk in response:
async for chunk in response:
for parsed_json in _utils.yield_parsed_json(chunk):
if parsed_json is not None:
yield parsed_json
Expand Down