Skip to content

feat: add bigquery.ml.generate_text function #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GarrettWu merged 3 commits into from
Jan 26, 2026
Merged

feat: add bigquery.ml.generate_text function #2403

GarrettWu merged 3 commits into from
Jan 26, 2026
+237 −11

Conversation

@GarrettWu
Copy link
Contributor

@GarrettWu GarrettWu commented Jan 22, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@GarrettWu GarrettWu requested a review from shuoweil January 22, 2026 23:19
@GarrettWu GarrettWu self-assigned this Jan 22, 2026
@GarrettWu GarrettWu requested review from a team as code owners January 22, 2026 23:19
@review-notebook-app
Copy link

review-notebook-app bot commented Jan 22, 2026

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 22, 2026
shuoweil
shuoweil previously approved these changes Jan 23, 2026
View reviewed changes
@GarrettWu
feat: Pass options as struct to ML.PREDICT and ML.GLOBAL_EXPLAIN
58f647b 
This change corrects the SQL generation for  and  to pass the options as a struct, which is the correct syntax.

The snapshot tests have been updated to reflect these changes.
@GarrettWu GarrettWu added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 23, 2026
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 23, 2026
@GarrettWu GarrettWu removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 23, 2026
@shuoweil shuoweil self-requested a review January 26, 2026 19:32
@GarrettWu GarrettWu merged commit 5ac6810 into main Jan 26, 2026
26 of 27 checks passed
@GarrettWu GarrettWu deleted the garrettwu-bbq branch January 26, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuoweil shuoweil shuoweil approved these changes

Assignees

@GarrettWu GarrettWu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GarrettWu @shuoweil