chore: add v1.19 notifications channel routing and Broadcasting/queue retry docs - #198
Open
goravel-coder wants to merge 11 commits into
Open
chore: add v1.19 notifications channel routing and Broadcasting/queue retry docs#198goravel-coder wants to merge 11 commits into
goravel-coder wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notification.ChannelMail/notification.ChannelDatabaseconstants (so a channel typo fails at compile time instead of silently dropping a route), the notifiable model prefers the typedMailRoutable.RouteNotificationForMailandDatabaseRoutable.RouteNotificationForDatabaseroutes withRouteNotificationForas fallback, empty routes surfaceNotificationMailEmptyRoute/NotificationDatabaseEmptyRouteerrors, and the database-connection contract is renamed toNotificationWithDatabaseConnection.make:event --broadcast/--broadcast --nowscaffolding, with the Broadcasting page added to the sidebar.ShouldRetryretries with the attempt count persisted in the reservation, a driver-agnosticretry_aftercrashed-worker recovery option, millisecond-precision job timestamps, and the newReservedJob.Attempts()/Release()contract) and the "Upgrading To v1.19 From v1.18" guide, with the notifications feature intro updated to the renamed contracts and channel constants.Why
Goravel v1.19 introduces a first-party notifications module, and its channel-routing API now ships typed contracts. The notifications guide previously showed raw
"mail"/"database"literals and a switch-basedRouteNotificationFor; it now documents thenotification.ChannelMail/notification.ChannelDatabaseconstants and the typed notifiable-side routes (MailRoutable.RouteNotificationForMail,DatabaseRoutable.RouteNotificationForDatabase) that take precedence overRouteNotificationFor, including the exact fallback chain and theNotificationMailEmptyRoute/NotificationDatabaseEmptyRouteerrors. The connection contract is renamed toNotificationWithDatabaseConnectionsoDatabaseRoutableunambiguously means the typed route.This matters because routing failures now surface at compile time (constants) or as explicit errors (empty routes) instead of silently dropping delivery, and the docs mirror the framework's real precedence semantics from framework#1535. The v1.19 upgrade guide's notifications intro is kept in sync with the renamed contracts, and the Broadcasting/queue rework documentation from the same release round out the v1.19 upgrade path.