feat: add shippoAccountId request option#124
Open
spesherov wants to merge 1 commit intogoshippo:mainfrom
Open
Conversation
spesherov
force-pushed
the
feature/shippo-account-id-request-option
branch
from
28300b4 to
8c76369
Compare
spesherov
force-pushed
the
feature/shippo-account-id-request-option
branch
from
8c76369 to
806f17c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shippoAccountId?: stringtoRequestOptionsinsrc/lib/sdks.ts.SHIPPO-ACCOUNT-IDrequest header whenoptions.shippoAccountIdis provided.Why
Platform Account workflows require passing
SHIPPO-ACCOUNT-ID: <ShippoAccountID>to make API calls on behalf of a customer account.Note
Medium Risk
Touches core request construction for all SDK calls by conditionally injecting a new
SHIPPO-ACCOUNT-IDheader, which could affect request behavior if misused or if headers collide. Otherwise the change is small and backward-compatible (new optional field).Overview
Adds an optional
shippoAccountIdtoRequestOptionsand documents its Platform Account use.When provided, the client now includes
SHIPPO-ACCOUNT-ID: <id>on outgoing requests during request creation, enabling customer-scoped API calls.Reviewed by Cursor Bugbot for commit 806f17c. Bugbot is set up for automated code reviews on this repo. Configure here.