Skip to content

Conversation

@eternal-flame-AD
Copy link
Member

Gets rid of warnings like:

[MobX] Since strict-mode is enabled, changing (observed) observable values without using an action is not allowed. Tried to modify: CurrentUser@6.loggedIn

I don't find any behavioral breakage but wrapping them in actions should be more conformant.

doc: https://mobx.js.org/actions.html#asynchronous-actions

@eternal-flame-AD eternal-flame-AD requested a review from a team as a code owner January 21, 2026 03:23
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.15%. Comparing base (ad9b01e) to head (6b1b1ba).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #906   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files          56       56           
  Lines        2226     2226           
=======================================
  Hits         1762     1762           
  Misses        360      360           
  Partials      104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one remark, otherwise looks good.


public exists = (id: number) => this.stateOf(id).loaded;

@action
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other actions are defined in the constructor via makeObservable. The stores should either use this or the decorator syntax and not mix between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants