Modernized Java example code #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmattheis
reviewed
Dec 14, 2025
| import java.net.http.HttpRequest; | ||
| import java.net.http.HttpResponse; | ||
|
|
||
| public class GotifyClient { |
Member
There was a problem hiding this comment.
Can you explain what the modernization is? the class -> record change I can understand but the rest doesn't seem necessary.
Author
There was a problem hiding this comment.
Hi,
Sure - here are my comments:
- Java 11 is not supported anymore.
- bump version of jackson in maven section
- No need to instantiate a GotifyClient instance; for this example simply call a static method (sendPush).
- Format response in a nicer way
Member
There was a problem hiding this comment.
I disagree that
- No need to instantiate a GotifyClient instance; for this example simply call a static method (sendPush).
makes this better.
Java 11 is not supported anymore.
Not wrong, but the code runs with java11 and java25, so it doesn't really make sense.
I'll accept the changes of the jackson version and the migration from class -> record for the message class. Everything else, I don't want to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.