Feat: Add option to disable store call cache #6214
Open
+74
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitrovmaksim
force-pushed
the
feat/add-option-to-disable-call-cache
branch
from
b48728d to
5d80ef1
Compare
dimitrovmaksim
force-pushed
the
feat/add-option-to-disable-call-cache
branch
from
5d80ef1 to
f45feb5
Compare
dimitrovmaksim
force-pushed
the
feat/add-option-to-disable-call-cache
branch
from
14c8d6c to
e402cf9
Compare
Signed-off-by: Maksim Dimitrov <[email protected]>
Signed-off-by: Maksim Dimitrov <[email protected]>
dimitrovmaksim
force-pushed
the
feat/add-option-to-disable-call-cache
branch
from
e402cf9 to
c42495c
Compare
lutter
approved these changes
Jan 12, 2026
Collaborator
lutter
left a comment
lutter
left a comment
There was a problem hiding this comment.
Looks good; needs just a small touch-up for the docs
| - `GRAPH_STORE_DISABLE_CALL_CACHE`: Disables the store call cache entirely. Graph node will skip writing and reading from the | ||
| call cache. The buffered block call cache will still be enabled. This option may be useful | ||
| for indexers who are running their own RPC nodes. Disabling the store call cache may have | ||
| significant performance impact. (default: false) |
Collaborator
There was a problem hiding this comment.
What do you mean by The buffered block call cache - do you mean just the block cache?
Also, I would reword 'Disabling the store call cache may have significant performance impact' to something like 'Disabling the store call cache may have significant performance impact; the precise impact depends on how long an eth_call takes on average compared to how long a database lookup of a cached call result takes'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5513
What this PR does:
Introduces an environment variable
GRAPH_STORE_DISABLE_CALL_CACHEthat allows disabling the store call cache. The main motivation is to provide indexers, who use locally hosted RPC nodes, with an option to bypass the graph-node call cache.