Skip to content

feat: update to new Vue grammar scope name#4174

Open
KammererTob wants to merge 2 commits intographql:mainfrom
KammererTob:main
Open

feat: update to new Vue grammar scope name#4174
KammererTob wants to merge 2 commits intographql:mainfrom
KammererTob:main

Conversation

@KammererTob
Copy link
Copy Markdown
Contributor

This PR adjusts the graphql grammar to work with the new Vue grammar scope name.
Starting with version 3.2.0 of the Vue language tools the scope name was changed to "text.html.vue" instead of "source.vue" (See: vuejs/language-tools#5856).

I am not sure if the addition in the injectionSelector is necessary, since in my testing i did not notice any difference, so maybe someone more knowledgeable can give me guidance on this.

Closes: vuejs/language-tools#5969

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 20, 2026

🦋 Changeset detected

Latest commit: cf01e19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql-syntax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KammererTob
Copy link
Copy Markdown
Contributor Author

Just noticed that there already is a PR open for this: #4144

Feel free to close mine if you choose to go with that earlier one. Keeping this open just for visibility, since this completely breaks the Syntax Highlighting for Vue files at the moment.

@outluch
Copy link
Copy Markdown

outluch commented Mar 30, 2026

All checks passed, everything is ready. Please, merge this.
Vue + graphql (hasura) is heaven.

@trevor-scheer
Copy link
Copy Markdown
Contributor

trevor-scheer commented Apr 15, 2026

Thanks @KammererTob, I'm going to land the other one once I've got maintainer permissions sorted. Feel free to close this if you like, else I will once it lands.

Edit: this one's actually got a changeset while the other doesn't, so if the other isn't fixed once I have permissions then I may just merge this one. Maybe leave it open for now 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GraphQL Syntax highlighting broken since 3.2.x

4 participants