fix: tmpfile not supported on web error when using base64 result#563
Open
gorbypark wants to merge 2 commits intogre:masterfrom
Open
fix: tmpfile not supported on web error when using base64 result#563gorbypark wants to merge 2 commits intogre:masterfrom
gorbypark wants to merge 2 commits intogre:masterfrom
Conversation
…eb even when using base64 or file result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was pleasantly surprised this is working perfectly for my use case on the web, except for one small error thrown, even when the result option is set to base64. The release capture function (on web) was set to just throw an error, always.
Original:
I added a quick little conditional to only throw the error if options.results type is tmpfile.