Url encode directional change characters#391
Open
yadue wants to merge 2 commits intogregjacobs:masterfrom
Open
Url encode directional change characters#391yadue wants to merge 2 commits intogregjacobs:masterfrom
yadue wants to merge 2 commits intogregjacobs:masterfrom
Conversation
yadue
changed the title
yadue
changed the title
|
@gregjacobs any chance this can get reviewed and merged in if the fix is appropriate? thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's another approach to #377 issue. Not sure @gregjacobs if it's what you really meant but I'm leaving this for you. You can take it and merge it or prepare different solution based on this.
fixes #377