Merged
Conversation
cbullinger
added a commit
that referenced
this pull request
Apr 22, 2026
Addresses PR review #6 — the security-critical surface had zero tests. Adds table-driven coverage for: - verifySuggestedRule, the invariant the AI suggester depends on to decide whether to show a "not verified" warning. Covers every transform type (move/copy/glob/regex), pattern mismatches, target mismatches, and invalid regex. - NewLLMClient dispatch: empty/ollama/anthropic/unsupported, plus the "anthropic provider requires ANTHROPIC_API_KEY" guard. - anthropic client getters/setters and ErrModelManagementNotSupported returned by PullModel / DeleteModel. - stripJSONFences edge cases (fenced, unfenced, nested JSON). - Rune-aware truncate (multi-byte glyphs not cut mid-byte). The earlier operator_auth_test.go covers validateGitHubPAT role mapping and the 404→denied / 5xx→writer auth semantics; this completes the review's minimum bar.
cbullinger
added a commit
that referenced
this pull request
Apr 24, 2026
Addresses PR review #6 — the security-critical surface had zero tests. Adds table-driven coverage for: - verifySuggestedRule, the invariant the AI suggester depends on to decide whether to show a "not verified" warning. Covers every transform type (move/copy/glob/regex), pattern mismatches, target mismatches, and invalid regex. - NewLLMClient dispatch: empty/ollama/anthropic/unsupported, plus the "anthropic provider requires ANTHROPIC_API_KEY" guard. - anthropic client getters/setters and ErrModelManagementNotSupported returned by PullModel / DeleteModel. - stripJSONFences edge cases (fenced, unfenced, nested JSON). - Rune-aware truncate (multi-byte glyphs not cut mid-byte). The earlier operator_auth_test.go covers validateGitHubPAT role mapping and the 404→denied / 5xx→writer auth semantics; this completes the review's minimum bar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MongoDB URI already added as a gcloud secret