xds: Refactor to allow common code usage between the ext_proc client and server interceptors#12883
Open
kannanjgithub wants to merge 1 commit into
Open
xds: Refactor to allow common code usage between the ext_proc client and server interceptors#12883kannanjgithub wants to merge 1 commit into
kannanjgithub wants to merge 1 commit into
Conversation
kannanjgithub
force-pushed
the
ext-proc-common
branch
from
a4d7042 to
07629e0
Compare
kannanjgithub
force-pushed
the
ext-proc-common
branch
3 times, most recently
from
72f9b1f to
522db6e
Compare
…rpc.xds.internal.extproc, with public access modifier: 1. Otel metric instruments out of the client interceptor 2. Moved `KnownLengthInputStream` used during observability mode to send message to the data plane out of the client interceptor. Created a new class io.grpc.xds.ExternalProcessorUtil with the below. This class is kept here and not in the above sub-package because `toHeaderMap` operates on `HeaderMutationRulesConfig` which is package-private. 1. Method `outboundStreamFromByteString` used to construct the ProcessingRequest payload to Util as a static utility method. 2. Method `toHeaderMap` to Util.
kannanjgithub
force-pushed
the
ext-proc-common
branch
from
522db6e to
e2337b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved some of the util classes for ext_proc to a new sub package io.grpc.xds.internal.extproc, with public access modifier:
KnownLengthInputStreamused during observability mode to send message to the data plane out of the client interceptor.Created a new class io.grpc.xds.ExternalProcessorUtil with the below. This class is kept here and not in the above sub-package because
toHeaderMapoperates onHeaderMutationRulesConfigwhich is package-private.outboundStreamFromByteStringused to construct the ProcessingRequest payload to Util as a static utility method.toHeaderMapto Util.