autosharding: Implement gRFC A119 auto-sharding lb policy - #12989
Draft
shivaspeaks wants to merge 1 commit into
Draft
autosharding: Implement gRFC A119 auto-sharding lb policy#12989shivaspeaks wants to merge 1 commit into
shivaspeaks wants to merge 1 commit into
Conversation
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new gRPC Autosharding Load Balancing plugin (:grpc-autosharding), including protobuf definitions for the DynamicShardingService and the implementation of the AutoShardingLoadBalancer, AutoShardingLoadBalancerProvider, and AutoShardingPicker to dynamically route requests based on key-range assignments. A critical compilation issue was identified in AutoShardingLoadBalancer.java where PickResult.withNoResult() is incorrectly called with arguments.
Member
Author
|
Note: The unit tests are WIP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Auto-Sharding LB Policy following gRFC A119: https://github.com/easwars/proposal/blob/slicer/A119-autosharding-lb-policy.md
Note: this PR does not include xDS integration of autosharding lb.