Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

guardian / dotcom-rendering Public

Notifications You must be signed in to change notification settings
Fork 29
Star 260

Code
Issues 490
Pull requests 52
Discussions
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

Enhance message picker & fire new event for `banner:sign-in-gate`#15380

Merged

cemms1 merged 11 commits intomainguardian/dotcom-rendering:mainfrom

cemms1/enhance-message-pickerguardian/dotcom-rendering:cemms1/enhance-message-pickerCopy head branch name to clipboard

Mar 4, 2026

Conversation Commits11 (11)Checks Files changed

Merged

Enhance message picker & fire new event for `banner:sign-in-gate`#15380
cemms1 merged 11 commits intomainfrom
cemms1/enhance-message-picker

Commits

Commits on Mar 4, 2026

WIP - clearer messagePicker result

tomrf1
authored and
cemms1
committed
fix tests

tomrf1
authored and
cemms1
committed
fix epic

tomrf1
authored and
cemms1
committed
tidy up + add logging to view picked message in browser
cemms1
committed
fix types
cemms1
committed
temporarily skip failing tests
cemms1
committed
add additional metadata to PickMessageResult so we can fire banner:none for the sign in gate
cemms1
committed
fire separate event for the sign in gate + update comment explaining the purpose of the events
cemms1
committed
update tests for messagePicker & remove console logs from the function itself
cemms1
committed
return NoMessageSelected if errors in result handling
cemms1
committed
fix type issue with show value for braze banners system config
cemms1
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.