Open
Conversation
github-actions
bot
removed
the
run_chromatic
cemms1
force-pushed
the
cemms1/hosted-article-tweaks
branch
from
3235733 to
8f4d176
Compare
…r header and article body elements also adds side borders and includes some palette alterations for these content types
… small updates to desktop layout for headline and standfirst
cemms1
force-pushed
the
cemms1/hosted-article-tweaks
branch
from
d6b86c7 to
561c9ac
Compare
github-actions
bot
removed
the
run_chromatic
deedeeh
approved these changes
Feb 27, 2026
| format.design === ArticleDesign.HostedArticle || | ||
| format.design === ArticleDesign.HostedVideo || | ||
| format.design === ArticleDesign.HostedAudio; | ||
| format.design === ArticleDesign.HostedGallery; |
Contributor
There was a problem hiding this comment.
That's entirely my mistake which I just noticed now from my previous PR ArticleBody but it was a commit that I did after your review and I didn't request for a re-review so my apology for that!
| <main | ||
| data-layout="HostedArticleLayout" | ||
| lang={decideLanguage(frontendData.lang)} | ||
| dir={decideLanguageDirection(frontendData.isRightToLeftLang)} |
Contributor
There was a problem hiding this comment.
I noticed mostly all layouts have isRightToLeftLang as the property so maybe we could be consistent with what exists?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adjusts the grid layout for
HostedArticleLayoutto match the designs and the existing pages more closelyWe now have three grid layouts:
articlethe top level grid. This applies the side borders in the correct positions
headernested under the
articlegrid, this collects the main media, main media caption, headline and meta (share button) together into a page "header"also nested under the
articlegrid, the standfirst, the rest of the article body, the onward content and the call to action component fall into this gridThis now looks much closer to our new designs for these pages
Why?
As part of the work to migrate Hosted Content pages from frontend to dotcom-rendering
Screenshots