Open
Conversation
d30f6e4 to
b70f7af
Compare
b70f7af to
aa20753
Compare
aa20753 to
5dcd50a
Compare
abeddow91
reviewed
Mar 2, 2026
Comment on lines
+367
to
+377
| const sectionContent = (isInSlimHomepageTestVariant: boolean) => css` | ||
| margin: 0; | ||
| grid-column: content; | ||
|
|
||
| .hidden > & { | ||
| display: none; | ||
| } | ||
|
|
||
| grid-column: content; | ||
| ${from.wide} { | ||
| grid-column: ${isInSlimHomepageTestVariant ? '5 / 14' : 'content'}; | ||
| } |
Contributor
There was a problem hiding this comment.
Nit / personal preference: I think this would be slightly easier to read if the slim homepage styles were separated from the base sectionContent styles
Keeping the default layout styles distinct from the AB-specific override makes it clearer what the “normal” behaviour is.
Something like:
Suggested change
| const sectionContent = (isInSlimHomepageTestVariant: boolean) => css` | |
| margin: 0; | |
| grid-column: content; | |
| .hidden > & { | |
| display: none; | |
| } | |
| grid-column: content; | |
| ${from.wide} { | |
| grid-column: ${isInSlimHomepageTestVariant ? '5 / 14' : 'content'}; | |
| } | |
| const sectionContent = css` | |
| margin: 0; | |
| grid-column: content; | |
| .hidden > & { | |
| display: none; | |
| } | |
| }` | |
| const slimSectionContent = css` | |
| ${from.wide} { | |
| grid-column: '5 / 14'; | |
| }` | |
Then apply conditionally:
sectionContent,
slimifySectionForAbTest && slimSectionContent
Happy either way though, so i'll leave this up to you.
0e964fe to
908e8ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Implements the logic to render the Most Popular Front Right component in the following circumstances:
/ukwidebreakpoint)The AB test is set to ON but remains at 0%.
The show/hide container button is not displayed for the News, Features or More features container for users in the variant of this test.
Why?
As a part of the Slim Homepage AB test
Note that the slimmed down front sections now "fit" 40px columns in the grid rather than the 60px column grid that the page uses. If this AB test is successful and this feature implemented, we would ensure that the content is aligned to the 60px column grid, which will require a redesign. The AB test is an exploration of how users might interact with this content higher up on the page.
Screenshots