Upgrade to Play 3.0#61
Merged
Merged
Conversation
todo: work out why this is required
We switched to using the github workflow instead of sbt plugin for this a while ago
Member
Author
|
Deployed to CODE, publishing still works |
phillipbarron
approved these changes
May 22, 2024
phillipbarron
left a comment
phillipbarron
left a comment
There was a problem hiding this comment.
Tested in code - all working as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrades from to Play 2.8 to Play 3.0 including change from Akka to Pekko.
This requires an upgrade to SBT 1.9.6 and Java 11. Upgrading to Java 11 caused a strange issue related to Logstash and Jackson, requiring us to explicitly exclude jackson-module-jaxb-annotations. See the long comment in build.sbt for a full explanation.
In addition, this bumps various dependencies and does some spring cleaning of
build.sbtandplugins.sbt.Finally, the tests were not working on M1 macbooks, which has been resolved by adding an explicit test dependency on a newer version jnr-unixsocket. See spotify/docker-client#1221 (unmerged and unreleased at present).
How to test
Deploy to code, check that you can still publish new articles in CODE composer