fix(extension): clear the 170 eslint-plugin-svelte v3 warnings - #285
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
fix(extension): clear the 170 eslint-plugin-svelte v3 warnings#285devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Guy MANDINA NZEZA <guyghost@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm lintreported 170 warnings in@pulse/extension(0 elsewhere). All are cleared and the rules that were temporarily downgraded towarnfor the v3 bump are back to their recommendederrorlevel, so regressions now fail CI.require-each-key(73) — every{#each}gets a key. Keys are identity/id-based where items are stable ((mission.id),(tab.id),(connectorId)), and index-based where values may legitimately repeat or are placeholders (scrapedmission.stackchips,Array(3)skeletons) to avoid duplicate-key runtime errors.no-useless-children-snippet(9) —<Button>{#snippet children()}X{/snippet}</Button>→<Button>X</Button>.prefer-writable-derived(1) —ApplicationsPage:prefer-svelte-reactivity(84) — turned off rather than migrated: every flagged site is either a non-reactive helper collection (toast timers, profile listeners, localMaps inside$derived.by) or a copy-on-writeMap/Setreassigned into$state(trackings = new Map(trackings).set(...)), which is already reactive.SvelteMap/SvelteSetwould only add proxy overhead.no-navigation-without-resolve(3) — turned off: SvelteKit-only rule, and the extension links to external platform URLs with no router to resolve against.Verification
pnpm format:checkpnpm lintpnpm typecheckpnpm test(2009 extension tests + all packages)pnpm buildChecklist
Link to Devin session: https://app.devin.ai/sessions/09e605ad12cc4cd7a0f44a2e05e564ae
Requested by: @guyghost