Skip to content

fix(extension): clear the 170 eslint-plugin-svelte v3 warnings - #285

Closed
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
devin/1785495558-fix-svelte-lint-warnings
Closed

fix(extension): clear the 170 eslint-plugin-svelte v3 warnings#285
devin-ai-integration[bot] wants to merge 1 commit into
developfrom
devin/1785495558-fix-svelte-lint-warnings

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

  • pnpm lint reported 170 warnings in @pulse/extension (0 elsewhere). All are cleared and the rules that were temporarily downgraded to warn for the v3 bump are back to their recommended error level, so regressions now fail CI.
  • require-each-key (73) — every {#each} gets a key. Keys are identity/id-based where items are stable ((mission.id), (tab.id), (connectorId)), and index-based where values may legitimately repeat or are placeholders (scraped mission.stack chips, Array(3) skeletons) to avoid duplicate-key runtime errors.
  • no-useless-children-snippet (9)<Button>{#snippet children()}X{/snippet}</Button><Button>X</Button>.
  • prefer-writable-derived (1)ApplicationsPage:
    -let nextActionInput = $state('');
    -$effect(() => { nextActionInput = isoToDateTimeLocal(selectedTracking?.nextActionAt ?? null); });
    +let nextActionInput = $derived(isoToDateTimeLocal(selectedTracking?.nextActionAt ?? null));
  • prefer-svelte-reactivity (84) — turned off rather than migrated: every flagged site is either a non-reactive helper collection (toast timers, profile listeners, local Maps inside $derived.by) or a copy-on-write Map/Set reassigned into $state (trackings = new Map(trackings).set(...)), which is already reactive. SvelteMap/SvelteSet would only add proxy overhead.
  • no-navigation-without-resolve (3) — turned off: SvelteKit-only rule, and the extension links to external platform URLs with no router to resolve against.

Verification

  • pnpm format:check
  • pnpm lint
  • pnpm typecheck
  • pnpm test (2009 extension tests + all packages)
  • pnpm build

Checklist

  • No secrets, cookies, session tokens, or generated release artifacts committed
  • Core code remains pure; I/O stays in shell modules
  • Svelte changes use Svelte 5 runes only
  • Documentation updated when behavior or setup changes (n/a)

Link to Devin session: https://app.devin.ai/sessions/09e605ad12cc4cd7a0f44a2e05e564ae
Requested by: @guyghost

Co-Authored-By: Guy MANDINA NZEZA <guyghost@gmail.com>
@guyghost guyghost self-assigned this Jul 31, 2026
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pulse Ready Ready Preview Jul 31, 2026 11:02am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
pulse-dashboard Skipped Skipped Jul 31, 2026 11:02am

@guyghost
guyghost changed the base branch from main to develop July 31, 2026 11:06
@guyghost guyghost closed this Jul 31, 2026
@guyghost
guyghost deleted the devin/1785495558-fix-svelte-lint-warnings branch July 31, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant