Make Assembly files track as Assembly - #1474
Merged
Merged
Conversation
Contributor
Greptile SummaryThis PR makes Assembly file extensions resolve to the canonical
Confidence Score: 5/5This PR is safe to merge with minimal risk. The change is narrow and directly addresses the Assembly extension precedence issue. Tests cover the updated behavior for Assembly and existing custom entries. Files Needing Attention: No files require special attention.
What T-Rex did
Important Files Changed
Sequence DiagramsequenceDiagram
participant Client as Language detection caller
participant LU as LanguageUtils
participant Base as config/languages.yml
participant Custom as config/languages_custom.yml
participant Map as Extension lookup
Client->>LU: detect_from_extension(entity)
LU->>Base: load base language data
LU->>Custom: load custom overrides
LU->>LU: deep_merge arrays with union
LU->>LU: remove custom-owned extensions from other languages
LU->>Map: build extension_map from merged data
Map-->>LU: canonical language name
LU-->>Client: Assembly for configured assembly extensions
Reviews (9): Last reviewed commit: "Merge branch 'main' into main" | Re-trigger Greptile |
skyfallwastaken
requested changes
Jul 17, 2026
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
skyfallwastaken
enabled auto-merge (squash)
July 26, 2026 17:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Assembly file types were being tracked as a range of assembly derivatives.
Describe your changes
Fixes it by making Assembly file extensions be logged as Assembly
Screenshots / Media
None