Fix localized VSTACK and HSTACK names - #1748
Open
Tobiadefami wants to merge 2 commits into
Open
Conversation
|
@Tobiadefami thanks for the pull request. No CLA step needed here — our records show you signed the Contributor License Agreement on 2026-07-31. That signature came from our previous signing form and has been carried over, so there is nothing for you to re-sign. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 92ce125. Configure here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1748 +/- ##
========================================
Coverage 97.31% 97.31%
========================================
Files 195 195
Lines 15719 15719
Branches 3455 3384 -71
========================================
Hits 15297 15297
- Misses 414 422 +8
+ Partials 8 0 -8
🚀 New features to boost your workflow:
|
Performance comparison of head (6719cb9) vs base (61ead73) |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
hyperformula-docs | 6719cb9 | Commit Preview URL Branch Preview URL |
Aug 25 2026, 07:21 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
HyperFormula 3.4.0 shipped
VSTACKandHSTACKwith English placeholder names in language packs where Microsoft Excel uses localized names. This PR moves the previously reviewed localization fix out of the unrelated TAKE PR and into a dedicated change.This extracts the VSTACK/HSTACK portion of commit
b902d53bc, originally authored by Kuba Sekowski.Changes
SROVNAT.SVISLESROVNAT.VODOROVNĚVSTAKHSTAKVSTAPELNHSTAPELNAPILARVAPILARHVPINOHPINOASSEMB.VASSEMB.HFÜGG.HALMOZÁSVÍZSZ.HALMOZÁSSTACK.VERTSTACK.ORIZVSTAKKHSTAKKVERT.STAPELENHOR.STAPELENSTOS.PIONSTOS.POZJUNTARVJUNTARHВСТОЛБИКГСТОЛБИКDÜŞEYYIĞYATAYYIĞIndonesian and Swedish remain in English, matching Excel. The PR also adds source-verification guidance to
DEV_DOCS.mdand an Unreleased changelog entry.Source verification
All 14 localized pairs and the unchanged Indonesian and Swedish pairs were checked on 2026-08-25 against Microsoft Support's current individual VSTACK/HSTACK pages, using each page title and displayed formula syntax. This caught one mismatch in the original table: Danish is
VSTAK/HSTAK.Microsoft's Danish alphabetical function index currently conflicts with those individual pages, so
DEV_DOCS.mdnow requires checking the linked individual page rather than copying a name from the index alone.Migration note
This is a breaking change for formulas created with HyperFormula 3.4.0 that use English
VSTACKorHSTACKwhile one of the affected language packs is active. Those formulas must switch to the names listed above.Validation
Companion tests: handsontable/hyperformula-tests#44
git diff --checkpassed.Types of changes
Note
Medium Risk
Breaking change for localized formula parsing in 14 locales; runtime behavior of the functions is unchanged, but existing formulas using English names in those locales will fail until updated.
Overview
Replaces English placeholder names for VSTACK and HSTACK in 14 language packs (
csCZ,daDK,deDE,esES,fiFI,frFR,huHU,itIT,nbNO,nlNL,plPL,ptPT,ruRU,trTR) with Microsoft Excel’s localized names (e.g. GermanVSTAPELN/HSTAPELN, CzechSROVNAT.SVISLE/SROVNAT.VODOROVNĚ). English, Indonesian, and Swedish still useVSTACK/HSTACK.Documents the breaking change under Unreleased in
CHANGELOG.md.DEV_DOCS.mdnow requires verifying localized names against authoritative Excel sources, adds Microsoft’s localized alphabetical function list for newer functions, and says to keep English when Excel does not ship a localized name.Migration: formulas written under HyperFormula 3.4.0 with English
VSTACK/HSTACKwhile one of the affected locales is active must use the new localized names.Reviewed by Cursor Bugbot for commit 6719cb9. Bugbot is set up for automated code reviews on this repo. Configure here.