Skip to content

FE-1107: Port cook orchestration into code/executor tools#298

Merged
kostandinang merged 2 commits into
ka/fe-1154-executor-run-integrityfrom
ka/fe-1107-executor-surface-reconciliation
Jul 7, 2026
Merged

FE-1107: Port cook orchestration into code/executor tools#298
kostandinang merged 2 commits into
ka/fe-1154-executor-run-integrityfrom
ka/fe-1107-executor-surface-reconciliation

Conversation

@kostandinang

@kostandinang kostandinang commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Stack Context

FE-1107 closes executor surface residue after the KA executor lane landed the real execute_* run machinery. This PR is stacked after the executor run integrity/observability work and reconciles mode vocabulary, Pi adapter topology, prompt conduct, and canonical docs.

What?

  • Renames the live Specify-mode runtime id from elicit to specify while preserving the elicitor role and elicit skill name.
  • Moves executor execute_* Pi adapters and passive run-update observers from agent-runtime/ to src/.pi/extensions/executor/.
  • Retires live orchestrator_stub prompt/test/doc witnesses in favor of the active execute_* surface and explicit host-promotion acceptance boundary.
  • Pins executor observer contracts: tolerant run artifact reads, populated-plan preference, active stream tails, and stream corruption tolerance.
  • Updates SPEC/PLAN/topology/testing docs to match the current surface.
  • Records the post-PR ln-sync cleanup: FE-1107 now points at draft PR FE-1107: Port cook orchestration into code/executor tools #298, retired stub cleanup is no longer a live Parallel item, and the remaining executor card is marked retained-unconfirmed pending KA confirmation instead of being deleted.

Why?

The execution mechanism exists, but stale mode names and stub-era executor text made the product read as though Execute mode still had no live execution boundary. This keeps operational mode, product label, foreground role, Pi adapter ownership, and executor-run observer contracts separate and explicit.

Verification

  • npm run fix
  • Targeted runtime/executor suite: 14 files, 135 tests
  • npm run verify (214 test files passed, 1479 tests passed, build passed)
  • npm run check after the sync-only follow-up commit

kostandinang commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

@kostandinang kostandinang changed the title FE-1107: Reconcile executor surface FE-1107: Port cook orchestration into code/executor tools Jul 7, 2026
@kostandinang kostandinang marked this pull request as ready for review July 7, 2026 10:54
@cursor

cursor Bot commented Jul 7, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Wide rename of operational-mode ids and authority-matrix witnesses can break mode switch, tool gating, and run-update publishing if any call sites miss the migration; changes sit on execution-adjacent seams though verification reportedly passed full suite.

Overview
Reconciles FE-1107 executor-surface residue after the KA lane landed real run machinery: product copy and SPEC/PLAN/topology now describe Specify (specify) vs Execute (execute) instead of SPEC/CODE/elicit, and Execute is framed around live execute_* tools plus explicit-acceptance host apply—not orchestrator_stub.

Runtime and tests in the diff align witnesses to that vocabulary (mode picker/chrome, authority matrix using execute_status, executor concentricity, tool-policy messages, run-update observer path under executor/execute-run-updates).

Planning/docs mark executor prompt/topology reconciliation as largely built on draft PR #298; deferred memory/cards/executor-* cleanup stays until KA confirms. One executor card is flagged retained-unconfirmed despite checked acceptance boxes.

Reviewed by Cursor Bugbot for commit 12d64bf. Bugbot is set up for automated code reviews on this repo. Configure here.

@kostandinang kostandinang marked this pull request as draft July 7, 2026 10:56
@kostandinang kostandinang marked this pull request as ready for review July 7, 2026 10:58
@kostandinang kostandinang requested a review from lunelson July 7, 2026 11:02
@kostandinang kostandinang self-assigned this Jul 7, 2026
@kostandinang kostandinang merged commit 55c81ed into ka/fe-1154-executor-run-integrity Jul 7, 2026
8 of 9 checks passed
@kostandinang kostandinang deleted the ka/fe-1107-executor-surface-reconciliation branch July 7, 2026 11:24
kostandinang added a commit that referenced this pull request Jul 7, 2026
* FE-1154: Scope executor run integrity hardening

* FE-1154: Harden executor run integrity

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1155: Retire the orchestrator stub tool (#296)

* FE-1154: Block unprojectable executor dependencies

* FE-1154: Add executor run observability

* FE-1154: Fix executor integrity review findings

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1154: Serialize agent stream appends

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1154: Default omitted plan mode to greenfield

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1107: Port cook orchestration into code/executor tools (#298)

* FE-1107: Reconcile executor surface

* FE-1107: Sync executor surface memory

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
kostandinang added a commit that referenced this pull request Jul 7, 2026
* FE-1141: Scope executor run observer

* FE-1141: Make run metadata persistence atomic

* FE-1141: Add execute.* run observer read projections

* FE-1141: Add /runs observer web routes

* FE-1141: Publish run-scoped update topics from execute tools

* FE-1141: Reconcile plan after run observer tracer

* FE-1141: Close out run observer: petri raw view and contract locks

* FE-1141: Sync plan with landed executor arc and in-flight wave

* FE-1141: Publish run updates per drive step

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1141: Serve the SPA fallback for runs deep links

* FE-1141: Tolerate invalid executor run directories

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1154: Scope executor run integrity hardening

* FE-1154: Harden executor run integrity

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1155: Retire the orchestrator stub tool (#296)

* FE-1154: Block unprojectable executor dependencies

* FE-1154: Add executor run observability

* FE-1154: Fix executor integrity review findings

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1154: Serialize agent stream appends

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1154: Default omitted plan mode to greenfield

Co-authored-by: Cursor <cursoragent@cursor.com>

* FE-1107: Port cook orchestration into code/executor tools (#298)

* FE-1107: Reconcile executor surface

* FE-1107: Sync executor surface memory

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants