FE-1133: Add drawer to ds#8971
Conversation
PR SummaryMedium Risk Overview Dialog is refactored to reuse shared overlay header/body/footer ( Introduces Reviewed by Cursor Bugbot for commit da63911. Bugbot is set up for automated code reviews on this repo. Configure here. |
439e631 to
15b7329
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 15b7329. Configure here.
15b7329 to
da63911
Compare
lunelson
left a comment
There was a problem hiding this comment.
Looks good; but I don't see any difference between the two versions, i.e. with/without partitioned footer?
|
The partitioned footer version has a grey background, otherwise white if a footer is provided - ideally would move this to a prop on the footer component but i then have to do some nasty data shuffling so that the parent can get the right css |

🌟 What is the purpose of this PR?
Adds a new Drawer component to the DS.
Updates Dialog to share many of the same internal components/styling + improves some of the nesting and mounting/unmounting animations.
Add a use-avoid-scroll-width-change hook so that expandable content inside drawers/dialogs doesn't trigger reflow when a scrollbar gets added/removed.
Also adds the duration tokens to panda so that some ark animations work properly (and fixes new panda css errors caused by adding the tokens)
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR: