Open
Conversation
Signed-off-by: Anton Alexeyev <alexeyev.anton@gmail.com>
|
Connected to Huly®: UBERF-13832 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new dynamic participants layout for Office meetings with automatic grid positioning based on container size and participant count. The layout replaces the previous fixed grid system with an adaptive algorithm that optimizes tile sizes and column counts.
- New dynamic grid layout algorithm that calculates optimal tile sizes and column arrangements
- Removed conditional video tab creation and simplified meeting widget setup
- Enhanced responsive design with proper aspect ratio handling and ResizeObserver integration
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
plugins/love-resources/src/utils.ts |
Simplified createMeetingWidget to always include video tab |
plugins/love-resources/src/types.ts |
Removed unused DefSeparators import and loveSeparators constant |
plugins/love-resources/src/components/meeting/widget/VideoTab.svelte |
Added height: 100% to container styling |
plugins/love-resources/src/components/meeting/ParticipantsListView.svelte |
Major refactor with dynamic grid layout algorithm and ResizeObserver |
plugins/love-resources/src/components/meeting/ControlExt.svelte |
Updated createMeetingWidget call to remove video parameter |
plugins/love-resources/src/components/meeting/ControlBarContainer.svelte |
Fixed hardcoded gap value in responsive styles |
plugins/love-resources/src/components/VideoPopup.svelte |
Replaced Scroller with direct div and simplified layout structure |
plugins/love-resources/src/components/Room.svelte |
Complete layout restructure with new separator system and responsive design |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
plugins/love-resources/src/components/meeting/ParticipantsListView.svelte
Show resolved
Hide resolved
plugins/love-resources/src/components/meeting/ParticipantsListView.svelte
Show resolved
Hide resolved
plugins/love-resources/src/components/meeting/ParticipantsListView.svelte
Show resolved
Hide resolved
plugins/love-resources/src/components/meeting/ParticipantsListView.svelte
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An experimental version of the new meeting layout. The PR is primarily intended to gather feedback, and if the reaction is positive, it will be further refined.

