Allow early configuration of devise models - #5853
Conversation
As of Rails 8, which enables lazy-loaded routes by default, Devise configuration particularly in test environments consistently breaks because tests begin running before routes have been loaded. This causes Devise (and therefore Warden) to operate with only partial configuration, particularly, a stale default_scope among other things. This change includes a new method to create a skeleton Mapping object which can be used to indicate a Devise-enabled model class that will be used for authentication before the route loading step has been completed. This object will have its configuration finalized once routes have been completed, and the Devise routes for that object are properly drawn. This is backwards compatible with the current route-centric configuration.
|
Thank you for working on this! I've tested this solution against a mini app that reproduces a scenario I faced with a project where we built a custom Warden strategy for a header-based authentication: https://github.com/thoughtbot/devise-eager-load-issue-demo (see this branch). It works well, but without the Devise model mapping configuration requirement that this introduces, it would introduce a regression on the next version since all requests would fail to authenticate going forward, which we may be hesitant to add. I wonder if there's a way to have this solution where people can opt-in to use it without introducing the regression. Do you have any ideas? I'd be happy to help digging. |
|
@clarissalimab thanks for testing this out, that's a great point. I've fixed that by updating the For the maintainers: to clarify my goals here, what I mean by "backwards compatible" is that it should be possible to update to a version with this change without making any configuration changes at all. I'm currently achieving this using a "last config wins" strategy if non-route configurations are declared in both locations, but there are a few other options to do this more intelligently and I'm happy to discuss that if we deem this a strategy worth pursuing. The "early config" stage should be entirely optional for projects where the existing route-based configuration is still working. |
3 participants
As of Rails 8, which enables lazy-loaded routes by default, Devise configuration particularly in test environments consistently breaks because tests begin running before routes have been loaded. This causes Devise (and therefore Warden) to operate with only partial configuration, particularly, a stale default_scope among other things.
This change includes a new method to create a skeleton Mapping object which can be used to indicate a Devise-enabled model class that will be used for authentication before the route loading step has been completed. This object will have its configuration finalized once routes have been completed, and the Devise routes for that object are properly drawn.
This is backwards compatible with the current route-centric configuration.