LineEvaluator to stop iterating when reached end#1699
Merged
Conversation
We want to handle route with width so neighbor tiles should be included so there's > condition to allow that, this leads to extra iteration. It's still present for widths bigger than one but it's hidden by neighbors. Relates-To: MINOR Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1699 +/- ##
==========================================
+ Coverage 80.31% 80.32% +0.01%
==========================================
Files 356 356
Lines 14279 14281 +2
Branches 1563 1563
==========================================
+ Hits 11468 11471 +3
+ Misses 2183 2181 -2
- Partials 628 629 +1
🚀 New features to boost your workflow:
|
mykolamalik
approved these changes
Jun 10, 2026
andrey-kashcheev
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to handle route with width so neighbor tiles should be included so there's > condition to allow that, this leads to extra iteration and extra tile. It still present for widths bigger than one but it's hidden by neighbours.
Relates-To: MINOR