Skip to content

Add MtlsTokenProvider for mTLS authentication - #1722

Open
rustam-gamidov-here wants to merge 1 commit into
masterfrom
rga/finalise-mtls-poc-datasdk-105
Open

Add MtlsTokenProvider for mTLS authentication#1722
rustam-gamidov-here wants to merge 1 commit into
masterfrom
rga/finalise-mtls-poc-datasdk-105

Conversation

@rustam-gamidov-here

Copy link
Copy Markdown
Collaborator

Implementing auto refreshing in place not using AutoRefreshToken and TokenEndpoint for simplicity and because mtls endpoint has very simple list of arguments and some features implemented in client authentication may be not supported at the moment.

Relates-To: DATASDK-105

@rustam-gamidov-here
rustam-gamidov-here force-pushed the rga/finalise-mtls-poc-datasdk-105 branch from 834a1de to aa8dc80 Compare August 21, 2026 07:18
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.45324% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.48%. Comparing base (6363d4f) to head (582e352).

Files with missing lines Patch % Lines
...p-cpp-sdk-authentication/src/MtlsTokenProvider.cpp 85.19% 6 Missing and 6 partials ⚠️
...dk-authentication/src/AuthenticationClientImpl.cpp 86.00% 3 Missing and 4 partials ⚠️
...ion/include/olp/authentication/MtlsTokenProvider.h 66.67% 2 Missing ⚠️
...pp-sdk-authentication/src/AuthenticationClient.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1722      +/-   ##
==========================================
+ Coverage   80.34%   80.48%   +0.14%     
==========================================
  Files         356      358       +2     
  Lines       14295    14432     +137     
  Branches     1565     1583      +18     
==========================================
+ Hits        11485    11615     +130     
+ Misses       2178     2177       -1     
- Partials      632      640       +8     
Files with missing lines Coverage Δ
.../include/olp/authentication/AuthenticationClient.h 100.00% <ø> (ø)
...ion/include/olp/authentication/MtlsTokenProvider.h 66.67% <66.67%> (ø)
...pp-sdk-authentication/src/AuthenticationClient.cpp 94.29% <0.00%> (-5.71%) ⬇️
...dk-authentication/src/AuthenticationClientImpl.cpp 81.85% <86.00%> (+0.65%) ⬆️
...p-cpp-sdk-authentication/src/MtlsTokenProvider.cpp 85.19% <85.19%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rustam-gamidov-here
rustam-gamidov-here force-pushed the rga/finalise-mtls-poc-datasdk-105 branch 3 times, most recently from 41abb93 to bbfe1d3 Compare August 21, 2026 15:49
Implementing auto refreshing in place not using AutoRefreshToken and
TokenEndpoint for simplicity and because mtls endpoint has very
simple list of arguments and some features implemented in client
authentication may be not supported at the moment.

Relates-To: DATASDK-105

Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@rustam-gamidov-here
rustam-gamidov-here force-pushed the rga/finalise-mtls-poc-datasdk-105 branch from bbfe1d3 to 582e352 Compare August 21, 2026 16:58
@rustam-gamidov-here
rustam-gamidov-here marked this pull request as ready for review August 21, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant