fix: address clang-tidy 17 errors - #1723
Open
isidorowiczdev wants to merge 5 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1723 +/- ##
==========================================
+ Coverage 80.34% 80.39% +0.05%
==========================================
Files 356 356
Lines 14295 14294 -1
Branches 1565 1566 +1
==========================================
+ Hits 11485 11491 +6
+ Misses 2178 2174 -4
+ Partials 632 629 -3
🚀 New features to boost your workflow:
|
isidorowiczdev
force-pushed
the
datasdk-104
branch
from
August 21, 2026 09:59
9c3d6f3 to
ee062bb
Compare
CI enables clang-tidy with -warnings-as-errors, and three checks were failing the build: - clang-analyzer-cplusplus.NewDeleteLeaks (24+ sites across TokenEndpointImpl, IndexLayerClientImpl, VolatileLayerClientImpl, VersionedLayerClientImpl, StreamLayerClientImpl): Every flagged call path was traced end-to-end and contains zero raw new/delete; ownership is shared_ptr/std::function throughout, so each site is suppressed with NOLINTNEXTLINE - clang-analyzer-deadcode.DeadStores (Crypto.cpp:171): ComputeSha256 mutated `value` via `>>=` when packing the last output byte, a redundant shift whose result was never read; changed to non-mutating `>>`. - clang-analyzer-optin.cplusplus.VirtualCall (SignInResultImpl.cpp:95): the constructor called virtual IsValid() instead of reading is_valid_ directly Resolves: DATASDK-104 Signed-off-by: Iwo Sidorowicz <iwo.sidorowicz@here.com>
isidorowiczdev
force-pushed
the
datasdk-104
branch
2 times, most recently
from
August 21, 2026 10:41
c6946dd to
70282cb
Compare
Add clang-tidy 17 job to the pipeline Resolves: DATASDK-104 Signed-off-by: Iwo Sidorowicz <iwo.sidorowicz@here.com>
isidorowiczdev
force-pushed
the
datasdk-104
branch
from
August 21, 2026 10:44
70282cb to
75a0d29
Compare
Chmod fix for clang-tidy script Resolves: DATASDK-104 Signed-off-by: Iwo Sidorowicz <iwo.sidorowicz@here.com>
Move each comment directly above the `[=](...)`. Resolves: DATASDK-104 Signed-off-by: Iwo Sidorowicz <iwo.sidorowicz@here.com>
isidorowiczdev
force-pushed
the
datasdk-104
branch
from
August 21, 2026 11:31
0f4d83d to
2ba7e62
Compare
Revert formatting Resolves: DATASDK-104 Signed-off-by: Iwo Sidorowicz <iwo.sidorowicz@here.com>
| "${PWD}/olp-cpp-sdk-core/.*" \ | ||
| "${PWD}/olp-cpp-sdk-authentication/.*" \ | ||
| "${PWD}/olp-cpp-sdk-dataservice-read/.*" \ | ||
| "${PWD}/olp-cpp-sdk-dataservice-write/.*" No newline at end of file |
Collaborator
There was a problem hiding this comment.
please update copyright blocks in changed files
maybe added scripts should have it as well, check other scripts in the reposotory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI enables clang-tidy with -warnings-as-errors, and three checks
were failing the build:
clang-analyzer-cplusplus.NewDeleteLeaks (24+ sites across
TokenEndpointImpl, IndexLayerClientImpl, VolatileLayerClientImpl,
VersionedLayerClientImpl, StreamLayerClientImpl): Every flagged
call path was traced end-to-end and contains zero raw new/delete;
ownership is shared_ptr/std::function throughout, so each site
is suppressed with NOLINTNEXTLINE
clang-analyzer-deadcode.DeadStores (Crypto.cpp:171): ComputeSha256
mutated
valuevia>>=when packing the last output byte, aredundant shift whose result was never read; changed to
non-mutating
>>.clang-analyzer-optin.cplusplus.VirtualCall (SignInResultImpl.cpp:95):
the constructor called virtual IsValid() instead of reading
is_valid_ directly