Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
+ Coverage 72.43% 72.56% +0.12%
==========================================
Files 301 300 -1
Lines 11005 10986 -19
==========================================
Hits 7972 7972
+ Misses 2144 2125 -19
Partials 889 889
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Some considerations:
|
5f9b15c to
be4a77e
Compare
|
The manpage output (as well as the generated markdown docs) would have a way better table view if the tables are printed using markdown format. Our table renderer already supports this, we just need to find a way to switch between the pretty print and markdown. I used a custom config option for now but it doesn't seem to work, because viper is not loaded if you only generate docs/manpages. I'll have a look at this another time. |
b47f89d to
305377e
Compare
305377e to
d4b548c
Compare
apricote
left a comment
There was a problem hiding this comment.
Looking good in general. Please document the new release artifacts for users. Should we mark them as experimental at first?
|
Docs have been updated now.
Maybe, but I'm not sure if this would be confusing with the way we use the |
|
I think the first paragraph from the experimental section applies here as well:
|

This PR adds the following package files to releases:
hcloud-cli-1.59.0-1.aarch64.rpmhcloud-cli-1.59.0-1.x86_64.rpmhcloud-cli_1.59.0_amd64.debhcloud-cli_1.59.0_arm64.deb