Conversation
mlz-EM
reviewed
Aug 20, 2026
| @@ -118,34 +125,34 @@ class RandomObjectProps(Dataclass): | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
For future? When reconstruction runs on a CUDA-backed array module and drop_nans removes at least one raster pattern, mask is a device array while scan_meta['raster_rows'] and raster_cols are NumPy arrays. Indexing those arrays with ~mask attempts to convert the device mask to NumPy and fails (for example, PyTorch reports that CUDA tensors cannot be converted directly), so NaN filtering breaks on GPU raster scans. Convert the mask to a host NumPy boolean array for the metadata indexing while retaining the backend mask for scan and pattern arrays.
mlz-EM
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new features to HDF5 state format, including probe and object type (in support of parameterized probe/object) as well as probe, object, and scan metadata. This change is backwards compatible (can open old HDF5 states with new phaser) but not forwards compatible (can't open new HDF5 states with old phaser).