Improve advisory ignore matching and stale ignore warnings#1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from review of #1198.
id/aliases, but the audit displays merged groups, so ignoring the displayed primary ID (e.g. an EEF ID) only suppressed the sibling GHSA/NVD advisories if they cross-referenced that ID in their aliases — otherwise the same vulnerability showed under bothAdvisories:andIgnored advisories:and the audit still failed. Ignoring any identifier of a display group now suppresses all of its members, in bothmix hex.auditandmix deps.get, and the audit partitions advisories in a single pass instead of two.