fix(capture): address review nits from #1879 (rgba-only transparent check, glass dedup key)#1880
Open
xuanruli wants to merge 1 commit into
Open
fix(capture): address review nits from #1879 (rgba-only transparent check, glass dedup key)#1880xuanruli wants to merge 1 commit into
xuanruli wants to merge 1 commit into
Conversation
…ss dedup key - isFilledEl: require rgba( (not rgba?) for the zero-alpha check, so a solid rgb(0,0,0) nav CTA isn't misread as transparent and dropped. - button dedup key includes backdropFilter, mirroring the card dedup key so a frosted button variant doesn't collapse into its non-frosted sibling. - rgbToHex comment: clarify RGB channels stay comma-separated; only the alpha may follow a comma or slash. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1879 (merged before these nits landed). Addresses the three review nits from @miga-heygen.
isFilledEltransparent check — requirergba((notrgba?) for the zero-alpha test.rgba?\([^)]*,\s*0\s*\)matched the blue channel ofrgb(r, g, 0), so a solidrgb(0, 0, 0)nav CTA was misread as transparent and dropped. Onlyrgba()carries an explicit alpha.backdropFilter, mirroring the card dedup key, so a frosted-glass button variant doesn't collapse into its non-frosted sibling.rgbToHexcomment — clarify that RGB channels stay comma-separated (asgetComputedStylereturns them); only the alpha may follow a comma or slash.Tested:
bun run build,oxlint/oxfmtclean,vitest run src/capture/54/54.🤖 Generated with Claude Code