fix(engine): harden DOM mask visibility restore#1953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extraHideIdsand__render_frame_*replacement images.#1952 Repro Follow-up
I reproduced #1952 with the exact true-HDR minimal repro against
v0.7.31: sampled subtitle-bar pixels at t=1.5/4.5/7.5 are all blue (0000ff), matching the reported stuckSUB 2behavior.The same repro passes on current
mainand on this branch: samples are red/green/blue (ff0000,00ff00,0000ff). It also passes on this branch's parent78cca797f/v0.7.33, so this PR is not the root fix for #1952.The actual root fix for #1952 is already on
main:bb066077b/ PR #1935 (fix(producer): avoid reviving hidden DOM in HDR layers), included inv0.7.33.Validation
bunx oxfmt --check packages/engine/src/services/screenshotService.ts packages/engine/src/services/screenshotService.test.tsbunx oxlint packages/engine/src/services/screenshotService.ts packages/engine/src/services/screenshotService.test.tsbun run --filter @hyperframes/engine typecheckbun run --filter @hyperframes/engine buildbun run --filter @hyperframes/engine test src/services/screenshotService.test.tsbunx vitest run packages/producer/src/services/render/stages/captureHdrFrameShared.dom-mask.test.ts packages/producer/src/services/render/stages/captureHdrFrameShared.test.ts