Skip to content

fix(engine): harden DOM mask visibility restore#1953

Merged
miguel-heygen merged 1 commit into
mainfrom
fix/1952-hdr-dom-overlays
Jul 5, 2026
Merged

fix(engine): harden DOM mask visibility restore#1953
miguel-heygen merged 1 commit into
mainfrom
fix/1952-hdr-dom-overlays

Conversation

@miguel-heygen

@miguel-heygen miguel-heygen commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

#1952 Repro Follow-up

I reproduced #1952 with the exact true-HDR minimal repro against v0.7.31: sampled subtitle-bar pixels at t=1.5/4.5/7.5 are all blue (0000ff), matching the reported stuck SUB 2 behavior.

The same repro passes on current main and on this branch: samples are red/green/blue (ff0000, 00ff00, 0000ff). It also passes on this branch's parent 78cca797f / v0.7.33, so this PR is not the root fix for #1952.

The actual root fix for #1952 is already on main: bb066077b / PR #1935 (fix(producer): avoid reviving hidden DOM in HDR layers), included in v0.7.33.

Validation

  • bunx oxfmt --check packages/engine/src/services/screenshotService.ts packages/engine/src/services/screenshotService.test.ts
  • bunx oxlint packages/engine/src/services/screenshotService.ts packages/engine/src/services/screenshotService.test.ts
  • bun run --filter @hyperframes/engine typecheck
  • bun run --filter @hyperframes/engine build
  • bun run --filter @hyperframes/engine test src/services/screenshotService.test.ts
  • bunx vitest run packages/producer/src/services/render/stages/captureHdrFrameShared.dom-mask.test.ts packages/producer/src/services/render/stages/captureHdrFrameShared.test.ts

@miguel-heygen miguel-heygen changed the title fix(engine): preserve DOM mask visibility state fix(engine): harden DOM mask visibility restore Jul 5, 2026
@miguel-heygen miguel-heygen marked this pull request as ready for review July 5, 2026 14:24
@miguel-heygen miguel-heygen merged commit 56d4a70 into main Jul 5, 2026
65 checks passed
@miguel-heygen miguel-heygen deleted the fix/1952-hdr-dom-overlays branch July 5, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant