Skip to content

Fix http2 to http1 cookie header conversion - #203

Merged
pimterry merged 1 commit into
httptoolkit:mainfrom
krigga:main
Aug 21, 2026
Merged

Fix http2 to http1 cookie header conversion#203
pimterry merged 1 commit into
httptoolkit:mainfrom
krigga:main

Conversation

@krigga

@krigga krigga commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

AI disclosure: this PR uses AI generated code.

@CLAassistant

CLAassistant commented Aug 15, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@pimterry pimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks! Can you sign the CLA please? Just confirms that it's your code and you're happy to contribute it to the project.

@krigga

krigga commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Looks good thanks! Can you sign the CLA please? Just confirms that it's your code and you're happy to contribute it to the project.

I am happy to contribute, but I'm not sure I can sign this given that the code is AI generated due to the words "Your original works of authorship". If you're fine with it though, I will sign gladly.

@pimterry

Copy link
Copy Markdown
Member

Yes, I think that's fine. As far as I understand it, as long as you directed the LLM manually and you've reviewed the output, it's effectively original authorship. The edge case is fully autonomous contributions (agents opening PRs with their own code without human involvement) but humans using LLMs as assistance counts as normal authorship in most places AFAICT.

@krigga

krigga commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

Signed the CLA

@pimterry
pimterry merged commit b4d875f into httptoolkit:main Aug 21, 2026
10 checks passed
@pimterry

Copy link
Copy Markdown
Member

Merged, thanks @krigga. I'll publish this in a new 4.6.1 release in just a minute.

@pimterry

Copy link
Copy Markdown
Member

Oh and by the way, in case you're not aware, HTTP Toolkit Pro is free for all contributors to all https://github.com/httptoolkit repos. If that would be useful, just let me know your email (either here or by sending a message to opensource @ httptoolkit.com) and I'll set you up with an account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using mockttp as a proxy between a http2 client and an http1 upstream proxy results in incorrect cookie header conversion

3 participants