Skip to content

[pull] memtable_as_log_index from topling:memtable_as_log_index#4

Open
pull[bot] wants to merge 69 commits intohugegraph:memtable_as_log_indexfrom
topling:memtable_as_log_index
Open

[pull] memtable_as_log_index from topling:memtable_as_log_index#4
pull[bot] wants to merge 69 commits intohugegraph:memtable_as_log_indexfrom
topling:memtable_as_log_index

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Mar 15, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot locked and limited conversation to collaborators Mar 15, 2026
@pull pull bot added the ⤵️ pull label Mar 15, 2026
@rockeet rockeet force-pushed the memtable_as_log_index branch 2 times, most recently from 9b42dd6 to 5c00a65 Compare March 18, 2026 15:47
@rockeet rockeet force-pushed the memtable_as_log_index branch from 5c00a65 to 68fbc5f Compare March 18, 2026 15:53
@rockeet rockeet force-pushed the memtable_as_log_index branch from 538e4a3 to b0622bb Compare March 19, 2026 04:03
@rockeet rockeet force-pushed the memtable_as_log_index branch from b0622bb to 1aa07fa Compare March 19, 2026 04:04
@rockeet rockeet force-pushed the memtable_as_log_index branch from 70b0c77 to 8a40448 Compare March 20, 2026 07:00
@rockeet rockeet force-pushed the memtable_as_log_index branch from 8a40448 to 355304b Compare March 20, 2026 07:05
@rockeet rockeet force-pushed the memtable_as_log_index branch from e4ecd25 to 0892907 Compare March 20, 2026 10:09
@rockeet rockeet force-pushed the memtable_as_log_index branch from 9ef6c2c to 5635966 Compare April 2, 2026 10:30
@rockeet rockeet force-pushed the memtable_as_log_index branch from 9ff960d to 65af93a Compare April 10, 2026 17:48
@rockeet rockeet force-pushed the memtable_as_log_index branch from 65af93a to df5d3e9 Compare April 10, 2026 18:12
@rockeet rockeet force-pushed the memtable_as_log_index branch from 5325790 to c4e2f0b Compare April 11, 2026 15:21
@rockeet rockeet force-pushed the memtable_as_log_index branch from 41c8eac to 39c8f17 Compare April 13, 2026 16:57
Refactory of FilePicker was introduced at 2014-07-16
(0418e66), it harms
performance and make the code complicated.

This commit makes the code simpler and faster.

ToplingDB is more than 10x faster than RocksDB, the
improvement from this change is significant:

The latency is reduced from 260ns to 234ns on E5 2682 v4 in wsl2 with
-benchmarks=fillseq,compact,readrandom -value_size=15 -num=100000000
in readrandom DBImpl::Get consumes 73%, others are db_bench framework,
the DBImpl::Get consumes 234*73% = 170ns
@rockeet rockeet force-pushed the memtable_as_log_index branch from 39c8f17 to 5669b35 Compare April 13, 2026 16:58
This change make the code simpler and faster.
Now it is 230ns, 4ns is reduced.
@rockeet rockeet force-pushed the memtable_as_log_index branch from 821371b to 3396bce Compare April 13, 2026 22:24
rockeet added 2 commits April 14, 2026 17:59
With template trick, propagate template param
PerfStepTimer and StopWatchNano, improves
3ns, about 1.5%.
@rockeet rockeet force-pushed the memtable_as_log_index branch from c187f03 to c172d98 Compare April 14, 2026 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant