fix(rt): remove automatic span propagation from TokioExecutor #259
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tracing` feature previously attached the current span to all futures spawned by `TokioExecutor::execute`. This caused application-level spans to incorrectly extend beyond their intended endpoints when background tasks (connection dispatchers, pool maintenance) outlived the original request. The `tracing` feature flag is preserved as a no-op for backwards compatibility. Clients requiring span propagation should wrap futures manually or implement their own `Executor<Fut>`. See hyperium/hyper#3904 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there -- thanks so much for hyper!
Per hyperium/hyper#3904, the
tracingfeature previously attached the current span to all futures spawned byTokioExecutor::execute. This caused application-level spans to incorrectly extend beyond their intended endpoints when background tasks (connection dispatchers, pool maintenance) outlived the original request.It seems like clients requiring span propagation should probably instead instrument futures at their call sites of
execute, or implement their ownExecutor<Fut>as needed per their context (e.g. attaching to some separate root span).This change removes the incorrect span propagation, but keeps the
tracingfeature flag for backwards compatibility.Thanks for your consideration!