Skip to content

Conversation

@tim-mwangi
Copy link
Collaborator

Description

SpanFromContext is used by the otel http and grpc instrumentation. StartSpan already adds service.instance.id attribute. So adding it in SpanFromContext as well

Testing

Manual testing

…nction

This is used by the otel http and grpc instrumentation. StartSpan already adds service.instance.id attribute. So adding it in SpanFromContext as well
@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.35%. Comparing base (0dd308a) to head (77a288e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
instrumentation/opentelemetry/span.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   61.14%   53.35%   -7.79%     
==========================================
  Files          59       59              
  Lines        2697     2699       +2     
==========================================
- Hits         1649     1440     -209     
- Misses        967     1185     +218     
+ Partials       81       74       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tim-mwangi tim-mwangi merged commit f2a8448 into main May 1, 2025
4 of 7 checks passed
@tim-mwangi tim-mwangi deleted the span-from-context branch May 1, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants