Skip to content

Conversation

@tim-mwangi
Copy link
Collaborator

Description

Upgrade to otel go v1.36.0

Testing

Manual testing.

Checklist:

  • [ ✅ ] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [✅ ] Any dependent changes have been merged and published in downstream modules

}

wait := make(chan error)
wait := make(chan error, 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not have to close this anymore?

Copy link
Collaborator Author

@tim-mwangi tim-mwangi Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently. It's copied from otel go's batch span processor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh okay

@codecov
Copy link

codecov bot commented Jun 8, 2025

Codecov Report

Attention: Patch coverage is 1.23839% with 319 lines in your changes missing coverage. Please review.

Project coverage is 47.79%. Comparing base (f2a8448) to head (341bf5a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...try/grpcunaryinterceptors/grpcunaryinterceptors.go 0.00% 200 Missing ⚠️
...tion/opentelemetry/grpcunaryinterceptors/config.go 0.00% 84 Missing ⚠️
...lemetry/grpcunaryinterceptors/metadata_supplier.go 0.00% 31 Missing ⚠️
...n/hypertrace/google.golang.org/hypergrpc/client.go 0.00% 1 Missing ⚠️
...n/hypertrace/google.golang.org/hypergrpc/server.go 0.00% 1 Missing ⚠️
...atchspanprocessor/batch_span_processor.modified.go 0.00% 1 Missing ⚠️
instrumentation/opentelemetry/metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   53.35%   47.79%   -5.57%     
==========================================
  Files          59       62       +3     
  Lines        2699     3013     +314     
==========================================
  Hits         1440     1440              
- Misses       1185     1499     +314     
  Partials       74       74              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tim-mwangi tim-mwangi merged commit 0e09d2c into main Jun 25, 2025
4 of 7 checks passed
@tim-mwangi tim-mwangi deleted the otel-go-1.36 branch June 25, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants