-
Notifications
You must be signed in to change notification settings - Fork 8
ENGTAI-63290: Upgrade to otel go v1.36.0 #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
|
|
||
| wait := make(chan error) | ||
| wait := make(chan error, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not have to close this anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently. It's copied from otel go's batch span processor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh okay
…ing because of this
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 53.35% 47.79% -5.57%
==========================================
Files 59 62 +3
Lines 2699 3013 +314
==========================================
Hits 1440 1440
- Misses 1185 1499 +314
Partials 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Upgrade to otel go v1.36.0
Testing
Manual testing.
Checklist: