fix: Cors::varyHeader bug with multiple Vary headers
#318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The varyHeader method had a bug when handling responses with multiple Vary header values: - Used wrong arguments: passed the header value as the header name - Passed `false` as the header value (invalid) - Didn't assign the result, so the line did nothing Fixed by simplifying to always use implode() to combine existing Vary header values with the new header. Added tests covering: - Adding Vary header when none exists - Appending to existing single header - Not duplicating existing headers - Handling multiple Vary header values (the bug case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The varyHeader method had a bug when handling responses with multiple Vary header values:
falseas the header value (invalid)Fixed by simplifying to always use implode() to combine existing Vary header values with the new header.
Added tests covering: