fix: InteractsWithSession to generate session ID before start #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using withSession() in tests with cache-based session drivers (redis, memcached, etc.), the startSession() method would fail because start() was called without first setting a session ID. CacheBasedSessionHandler has strict string type hints on its read/write methods, so passing null caused a TypeError. In production, StartSession middleware calls setId($cookie) before start(), which generates an ID if the cookie is null. The test trait now mirrors this behavior by calling setId(null) before start() when no ID exists. Fixes: TypeError when using withSession() with non-array session drivers
albertcht
reviewed
Dec 27, 2025
The return type `static` is already enforced by PHP's type system, making these tests unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
withSession()in tests with cache-based session drivers (redis, memcached, etc.), thestartSession()method would fail becausestart()was called without first setting a session ID. CacheBasedSessionHandlerhas strict string type hints on its read/write methods, so passing null caused a TypeError.In production, StartSession middleware calls
setId($cookie)beforestart(), which generates an ID if the cookie is null. The test trait now mirrors this behavior by calling setId(null) before start() when no ID exists.Fixes: TypeError when using withSession() with non-array session drivers