Skip to content

Allow interaction authorization #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unfamiliarS wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −3
Open

Allow interaction authorization #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions dbus-java-core/src/main/java/org/freedesktop/dbus/RemoteInvocationHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.freedesktop.dbus;

import org.freedesktop.dbus.annotations.DBusBoundProperty;
import org.freedesktop.dbus.annotations.MethodAllowInteractiveAutorization;
import org.freedesktop.dbus.annotations.MethodNoReply;
import org.freedesktop.dbus.connections.AbstractConnection;
import org.freedesktop.dbus.errors.NoReply;
Expand Down Expand Up @@ -196,6 +197,9 @@ public static Object executeRemoteMethod(boolean _methodCall, final RemoteObject
if (_m.isAnnotationPresent(MethodNoReply.class)) {
flags |= Flags.NO_REPLY_EXPECTED;
}
if (_m.isAnnotationPresent(MethodAllowInteractiveAutorization.class)) {
flags |= Flags.ALLOW_INTERACTIVE_AUTHORIZATION;
}
try {
String name = DBusNamingUtil.getMethodName(_m);
if (null == _ro.getInterface()) {
Expand Down
22 changes: 22 additions & 0 deletions ...re/src/main/java/org/freedesktop/dbus/annotations/MethodAllowInteractiveAutorization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package org.freedesktop.dbus.annotations;

import java.lang.annotation.ElementType;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;

/**
* Methods allow interactive autorization
*/
@Target(ElementType.METHOD)
@Retention(RetentionPolicy.RUNTIME)
@DBusInterfaceName("org.freedesktop.DBus.Method.AllowInteractiveAutorization")
public @interface MethodAllowInteractiveAutorization {

/**
* Annotation value, true by default
*
* @return true when a method allow interactive autorization, false otherwise
*/
boolean value() default true;
}
7 changes: 4 additions & 3 deletions dbus-java-core/src/main/java/org/freedesktop/dbus/messages/constants/Flags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@
* @since 5.0.0 - 2023-10-23
*/
public final class Flags {
public static final byte NO_REPLY_EXPECTED = 0x01;
public static final byte NO_AUTO_START = 0x02;
public static final byte ASYNC = 0x40;
public static final byte NO_REPLY_EXPECTED = 0x01;
public static final byte NO_AUTO_START = 0x02;
public static final byte ALLOW_INTERACTIVE_AUTHORIZATION = 0x04;
public static final byte ASYNC = 0x40;

private Flags() {

Expand Down