Add executable to collect file level collection parameters#223
Open
tmadlener wants to merge 12 commits into
Open
Add executable to collect file level collection parameters#223tmadlener wants to merge 12 commits into
tmadlener wants to merge 12 commits into
Conversation
Contributor
Author
|
Initial version done by Claude now with some cleanup and refactoring to cut down on the initial code duplication. |
jmcarcell
reviewed
Apr 23, 2026
jmcarcell
reviewed
Apr 23, 2026
No longer necessary because capturing in lambda has been removed
6718ca2 to
7d19fba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
check_col_paramsexecutable to collect a consistent set of collection parameters similar tocheck_missing_cols.getValsfunction toLCParametersto more easily retrieve all values associated to a keyENDRELEASENOTES
For context see the discussions in:
finalizeinLcio2EDM4hep.cppkey4hep/k4MarlinWrapper#478 (comment)TL;DR: In LCIO collection parameters can differ for every event. This is used for truly event level parameters, but also for what we refer to as metadata (or file level parameters) in Key4hep / Gaudi where one value is just repeated every event even if it doesn't change.
With this executable one can collect these values and make it possible to inject them into Gaudi before event processing starts, so that these values are always available when needed. This is slightly more up-front work for workflows that want to mix processors and algorithms, but it relieves the burden from the Gaudi framework to work around some of the core principles that are somewhat necessary for multithreading.