fixing issue with comparing generices argument with a non genericized… #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iains
requested changes
Dec 8, 2025
gcc/cp/contracts.cc
Outdated
| return contract_valid_p (TREE_VALUE (TREE_VALUE (attribute))); | ||
| } | ||
|
|
||
| int comparing_contracts; |
Owner
There was a problem hiding this comment.
I am very sorry I missed this on the first pass - adding global state to the compiler is not likely to be accepted (we are trying to move in the opposite direction - i.e. remove such state). IFF this is needed here, can it not be added to the scope or so? ... alternate suggestion below...
gcc/cp/cp-tree.h
Outdated
| /* Nonzero if we are matching contracts of two functions. Depending on | ||
| whether a decl has been genericized or not, PARM_DECL may be adjusted | ||
| to be an invisible reference. */ | ||
| extern int comparing_contracts; |
Owner
There was a problem hiding this comment.
instead of having global state here - perhaps a defaulted extra parm to the cp_tree_equal () fn would work (if we cannot use the current scope for some reason). That means one does not have to go through and adjust all the other callers - only the one from contracts.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… one
Thanks for taking the time to contribute to GCC! Please be advised that if you are
viewing this on
github.com, that the mirror there is unofficial and unmonitored.The GCC community does not use
github.comfor their contributions. Instead, we usea mailing list (
[email protected]) for code submissions, code reviews, andbug reports. Please send patches there instead.