Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
…ser_registration.form.allowed_field_definitions_identifiers" config
…vent handling order, in the way to allowed fields id filtering take place at correct time in form processing.
bnowak
force-pushed
the
fixed-user-register-form-to-work-with-allowed_field_definitions_identifiers-config
branch
from
d7d4531 to
7ac096a
Compare
ViniTou
approved these changes
Apr 22, 2026
barw4
approved these changes
Apr 22, 2026
Contributor
barw4
left a comment
barw4
left a comment
There was a problem hiding this comment.
I assume test is failing after switching back to PRE_SET_DATA?
bnowak
changed the title
user_registration.form.allowed_field_definitions_identifiers configuser_registration.form.allowed_field_definitions_identifiers config
Co-authored-by: Bartek Wajda <bartlomiej.wajda@ibexa.co>
Author
@barw4 yes. In fact I created failing tests first and fix commit as last one (the change from |
tbialcz
approved these changes
Apr 22, 2026
alongosz
approved these changes
Apr 22, 2026
konradoboza
approved these changes
Apr 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
From SF
7.2version ResizeFormListener added handling ofFormEvents::POST_SET_DATA, so our filtering out of not defined fields inuser_registration.form.allowed_field_definitions_identifiersdidn't impact form because it was done before (onFormEvents::POST_SET_DATAevent).It looks like it was adjusted in FieldCollectionType in version
5.0.0, but was missed here in UserRegisterType.For QA:
It worked in
4.6version, however in5.0with Symfony7.2internal\Symfony\Component\Form\Extension\Core\EventListener\ResizeFormListenerchanged its behaviour, which impacted our feature and it stopped working.Documentation: