Support CA-specific HTTP proxy settings#413
Merged
icing merged 2 commits intoicing:masterfrom Apr 17, 2026
Merged
Conversation
Allow the MDHttpProxy setting to be set per MDomain. The global MDHttpProxy setting is used by default. Closes icing#412
Contributor
Author
|
@icing What do you think of this PR? Do you have any suggestions on how I could improve it? |
Owner
|
@mkauf sorry, was a bit busy. Looks good. We could use a test for this. Something like |
Add integration tests
Contributor
Author
|
@icing Thank you for the suggestion! I have added integration tests. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the MDHttpProxy setting to be set per MDomain. The global MDHttpProxy setting is used by default.
Closes #412