refactor(system): add arguments to pollPartition and pollTopic#14
Merged
cesarcoatl merged 1 commit into8.3from Jan 21, 2026
Merged
Conversation
part of the kafka module
Reviewer's guide (collapsed on small PRs)Reviewer's GuideExtends the Kafka polling APIs to accept optional size and timeout controls, updating both the runtime implementations and their type stubs to keep signatures aligned for static checking and callers. Class diagram for updated Kafka polling functionsclassDiagram
class kafka {
+List~Any~ pollPartition(connector, topic, partition, offset, options, sizeCutoff, timeoutMs)
+List~Any~ pollTopic(connector, topic, groupId, options, sizeCutoff, timeoutMs)
}
class pollPartitionParams {
+connector: Union~str, unicode~
+topic: Union~str, unicode~
+partition: int
+offset: Union~str, unicode~
+options: Optional~Dict~Union~str, unicode~, Any~~
+sizeCutoff: Optional~int~
+timeoutMs: Optional~long~
}
class pollTopicParams {
+connector: Union~str, unicode~
+topic: Union~str, unicode~
+groupId: Union~str, unicode~
+options: Optional~Dict~Union~str, unicode~, Any~~
+sizeCutoff: Optional~int~
+timeoutMs: Optional~long~
}
kafka ..> pollPartitionParams : uses
kafka ..> pollTopicParams : uses
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of the kafka module
Summary by Sourcery
Extend Kafka polling APIs to support optional limits on record count and poll duration.
New Features:
Enhancements: